RATIS-2508. appendEntries log messages improvement.#1440
Open
szetszwo wants to merge 3 commits intoapache:masterfrom
Open
RATIS-2508. appendEntries log messages improvement.#1440szetszwo wants to merge 3 commits intoapache:masterfrom
szetszwo wants to merge 3 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Apr 28, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
Comment on lines
+105
to
+106
| : n == 1 ? "entry" + first | ||
| : n + " entries:" + first + "..." + last; |
Contributor
There was a problem hiding this comment.
Missing :?
Suggested change
| : n == 1 ? "entry" + first | |
| : n + " entries:" + first + "..." + last; | |
| : n == 1 ? "entry:" + first | |
| : n + " entries:" + first + "..." + last; |
Also, would = instead of : be better? Since AppendEntriesRequest#toString uses : as separator.
Comment on lines
+1700
to
+1702
| LOG.warn("{}: appendEntries* failed: {}", getMemberId(), toLogEntryTermIndexString(entries), t); | ||
| } else if (LOG.isDebugEnabled()) { | ||
| LOG.debug("{}: appendEntries* succeeded {}", getMemberId(), toLogEntryTermIndexString(entries)); |
Contributor
There was a problem hiding this comment.
nit: failed: {} has : but succeeded {} does not.
Contributor
Author
|
@adoroszlai , thanks for reviewing this! Just pushed a change to address your comments. |
adoroszlai
approved these changes
Apr 28, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for updating the patch, LGTM.
OneSizeFitsQuorum
approved these changes
Apr 29, 2026
Contributor
OneSizeFitsQuorum
left a comment
OneSizeFitsQuorum
left a comment
There was a problem hiding this comment.
LGTM~ Only a minor problem
| if (roleChangeChecking(electionTimeout)) { | ||
| LOG.info("{}: change to CANDIDATE, lastRpcElapsedTime:{}, electionTimeout:{}", | ||
| this, lastRpcTime.elapsedTime(), electionTimeout); | ||
| LOG.info("{}: change to CANDIDATE, lastRpcElapsedTime:{}ms, electionTimeout:{}", |
Contributor
There was a problem hiding this comment.
why we add ms for lastRpcElapsedTime but not electionTimeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RATIS-2508
Due to checkstyle line number limit (2000), this PR also refactors RaftServerImpl.