RATIS-2426. Fix memory leak in ServerRequestStreamObserver#1368
Open
ivandika3 wants to merge 14 commits intoapache:masterfrom
Open
RATIS-2426. Fix memory leak in ServerRequestStreamObserver#1368ivandika3 wants to merge 14 commits intoapache:masterfrom
ivandika3 wants to merge 14 commits intoapache:masterfrom
Conversation
ivandika3
changed the title
Add a static counter in GrpcServerProtocolService that tracks handleError closures where previousOnNext was not cleaned up. The test asserts the counter remains zero, which fails without the previousOnNext.set(null) fix. Made-with: Cursor
szetszwo
reviewed
Apr 27, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@ivandika3 , thanks for working on this! Please see the comment inlined. (Sorry that I missed this PR earlier.)
| if (event == Event.COMPLETE) { | ||
| onCompleted(); | ||
| } else { | ||
| cancelStream("stop due to " + event); |
Contributor
There was a problem hiding this comment.
We have the following call sequence:
- AppendLogResponseHandler.onError(..) / onCompleted() -> resetClient(..) -> stop()
In the gRPC example,
- onCompleted() implementation will response onCompleted() but
- onError(Throwable t) only calls logger.log(Level.WARNING, ...)
So, I think stop() should not call cancelStream(..)
| */ | ||
| @ParameterizedTest | ||
| @MethodSource("data") | ||
| public void testLogAppenderStreamCleanupOnRestart(Boolean separateHeartbeat) throws Exception { |
Contributor
There was a problem hiding this comment.
I tried to revert GrpcLogAppender and GrpcServerProtocolService (except for GRPC_SERVER_HANDLE_ERROR). Both testLogAppenderStreamCleanupOnRestart and testFollowerHandleErrorCleanup can pass. So, they probably cannot test the code change.
Contributor
Author
|
@szetszwo Thanks for the review. I'm still not 100% sure about this fix yet. I'll revisit this when I have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Please refer to https://issues.apache.org/jira/browse/RATIS-2426
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2426
How was this patch tested?
UT