PHOENIX-7751: Feature to validate table data using PhoenixSyncTable tool b/w source and target cluster#2419
Open
rahulLiving wants to merge 5 commits intoapache:5.2from
Open
PHOENIX-7751: Feature to validate table data using PhoenixSyncTable tool b/w source and target cluster#2419rahulLiving wants to merge 5 commits intoapache:5.2from
rahulLiving wants to merge 5 commits intoapache:5.2from
Conversation
…ool b/w source and target cluster (apache#2379)
haridsv
reviewed
Apr 24, 2026
|
|
||
| // We shouldn't see expired rows even with --raw-scan flag | ||
| Job job2 = runSyncTool(uniqueTableName, "--raw-scan"); | ||
| // Run sync tool after compaction - should detect mismatch (source has rows, target doesn't) |
Contributor
There was a problem hiding this comment.
Shouldn't we handle this filtering in the sync tool coproc? Otherwise, we will end up seeing a lot of false +ves.
Contributor
Author
There was a problem hiding this comment.
Yeah, we don't want to read expired rows. Thanks.
rahulLiving
commented
Apr 24, 2026
| scan.setAttribute(BaseScannerRegionObserverConstants.SYNC_TABLE_CHUNK_FORMATION, TRUE_BYTES); | ||
| scan.setAttribute(BaseScannerRegionObserverConstants.SKIP_REGION_BOUNDARY_CHECK, TRUE_BYTES); | ||
| scan.setAttribute(BaseScannerRegionObserverConstants.UNGROUPED_AGG, TRUE_BYTES); | ||
| ScanUtil.setScanAttributesForPhoenixTTL(scan, pTable, phoenixConn); |
Contributor
Author
There was a problem hiding this comment.
This seems to be useful for PhoenixTTLRegionScanner which is for view TTL, so not required.
added 2 commits
April 24, 2026 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.