feat: support reading blob files in data evolution flow#259
Merged
JingsongLi merged 2 commits intoapache:mainfrom Apr 17, 2026
Merged
feat: support reading blob files in data evolution flow#259JingsongLi merged 2 commits intoapache:mainfrom
JingsongLi merged 2 commits intoapache:mainfrom
Conversation
JingsongLi
reviewed
Apr 17, 2026
| } else { | ||
| let source_idx = sources.len(); | ||
| sources.push(FieldSource::BlobBunch { | ||
| bunch: BlobBunch::new(expected_row_count, false), |
Contributor
Author
There was a problem hiding this comment.
I removed the unused row_id_push_down flag and simplified BlobBunch::new.
| .unwrap_or_else(|e| panic!("Failed to write blob test file {path:?}: {e}")); | ||
| } | ||
|
|
||
| fn encode_delta_varints(values: &[i64]) -> Vec<u8> { |
Contributor
Author
There was a problem hiding this comment.
I removed the duplicated helper in blob.rs tests and reused blob_test_utils::encode_delta_varints.
JingsongLi
reviewed
Apr 17, 2026
| } | ||
|
|
||
| let mut builder = BinaryBuilder::new(); | ||
| for &position in positions { |
Contributor
There was a problem hiding this comment.
Is it possible to read blobs in parallel?
Contributor
Author
There was a problem hiding this comment.
I changed blob payload reads to bounded parallel reads with buffered(...) while preserving output order, and added a test for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #228
Add the minimal read-only
.blobread path forBlobType, so Rust can read Java-generated blob files in the existing data-evolution flow.Brief change log
.blobformat dispatch.blobreader forBlobTypeBinaryoutputDataEvolutionReaderwith rolling blob merge support via internal blob source planningTests
API and Format
Documentation