HDDS-15138. SCM safemode pipeline rules should honor default EC replication config.#10157
Open
aryangupta1998 wants to merge 1 commit intoapache:masterfrom
Open
HDDS-15138. SCM safemode pipeline rules should honor default EC replication config.#10157aryangupta1998 wants to merge 1 commit intoapache:masterfrom
aryangupta1998 wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Today SCM safemode pipeline exit checks are effectively hardcoded to
RATIS/THREE, which is incorrect when cluster default replication is EC. In EC-default deployments, safemode should validate pipelines for the configured default replication instead of onlyRATIS/THREE.This patch generalizes safemode pipeline validation to use
ReplicationConfig.getDefault(conf):HealthyPipelineSafeModeRulenow evaluates pipelines matching the configured default replication config and uses required node count from that config.OneReplicaPipelineSafeModeRulenow tracks/report-validates pipelines matching the configured default replication config.To keep behavior consistent, BackgroundPipelineCreator is updated to include EC pipeline creation when default replication type is EC, while preserving existing RATIS behavior when EC is not configured.
Expected outcome:
RATIS default: behavior remains unchanged.
EC default: safemode pipeline checks validate EC pipelines, and background creation can create EC pipelines accordingly.
Validation
Added/updated below SCM tests for EC-default and RATIS-default paths.
TestHealthyPipelineSafeModeRule
TestOneReplicaPipelineSafeModeRule
TestSCMSafeModeManager
TestBackgroundPipelineCreator
Note:
For EC-default setups in SCM safemode paths, ensure both are set:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15138
How was this patch tested?
Unit tests.