HDDS-15111. Remove PureJavaCrc32ByteBuffer (superceded by ChecksumByteBufferFactory)#10127
Draft
smengcl wants to merge 1 commit intoapache:masterfrom
Draft
HDDS-15111. Remove PureJavaCrc32ByteBuffer (superceded by ChecksumByteBufferFactory)#10127smengcl wants to merge 1 commit intoapache:masterfrom
smengcl wants to merge 1 commit intoapache:masterfrom
Conversation
smengcl
added
the
code-cleanup
Contributor
|
@smengcl , thanks for pointing out HDDS-4138 in HDDS-15098 and working on this! Let's wait for HDDS-10489 (and also HDDS-15115) since it may need some of the code. Will submit a PR soon. |
Contributor
|
@smengcl , both JIRAs are now merged. Please update this PR. Thanks for the waiting! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prompted by HDDS-15098, PureJavaCrc32ByteBuffer (and PureJavaCrc32CByteBuffer) are no longer used in production. Ozone switched away from it since HDDS-4138. Thus we can remove them.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15111
How was this patch tested?