Skip to content

test: cover resource id initializers#8146

Open
neu-hsc wants to merge 1 commit into
apache:2.xfrom
neu-hsc:codex/seata-1714-rm-datasource-tests
Open

test: cover resource id initializers#8146
neu-hsc wants to merge 1 commit into
apache:2.xfrom
neu-hsc:codex/seata-1714-rm-datasource-tests

Conversation

@neu-hsc

@neu-hsc neu-hsc commented Jun 19, 2026

Copy link
Copy Markdown

What this PR does

This PR adds focused unit coverage for the rm-datasource resource id initializer path:

  • verifies ResourceIdInitializerRegistry selects DB-specific initializers and falls back to the default initializer
  • covers query-string stripping for default and MySQL resource ids
  • covers MySQL load-balance host normalization
  • covers PostgreSQL currentSchema preservation and separator normalization
  • covers DM schema filtering, Oracle/Oscar username suffixing, and SQL Server identity property filtering

Why

This helps increase rm-datasource module test coverage for #1714 without changing runtime behavior.

Tests

Ran the focused Maven reactor test locally:

mvn -pl rm-datasource -am -Dtest=ResourceIdInitializerTest -DfailIfNoTests=false -DfailIfNoSpecifiedTests=false test

Local note: I used a temporary Maven settings file only to redirect the local repository away from my read-only Maven installation directory.

@neu-hsc neu-hsc marked this pull request as ready for review June 19, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant