Support loop element resolution during compensation#8127
Open
somiljain2006 wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8127 +/- ##
============================================
- Coverage 72.92% 72.70% -0.23%
+ Complexity 883 879 -4
============================================
Files 1327 1327
Lines 50769 50781 +12
Branches 6058 6062 +4
============================================
- Hits 37025 36919 -106
- Misses 10735 10870 +135
+ Partials 3009 2992 -17
🚀 New features to boost your workflow:
|
Contributor
Author
|
@funky-eyes @slievrly Can you review this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Re-evaluate the loop collection expression during compensation and reconstruct the loop element using the restored loop index. This allows compensation tasks within loop states to access the corresponding loop element and index through the state machine context.
Ⅱ. Does this pull request fix one issue?
Fixes #6776
Ⅲ. Why don't you add test cases (unit test/integration test)?
Added unit tests covering compensation-time expression evaluation and loop element reconstruction.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
N/A