[ISSUE #7993] Implement NoWait mechanism for database distributed lock#8111
Open
wushiyuanmaimob wants to merge 1 commit into
Open
[ISSUE #7993] Implement NoWait mechanism for database distributed lock#8111wushiyuanmaimob wants to merge 1 commit into
wushiyuanmaimob wants to merge 1 commit into
Conversation
…ed lock Under high concurrency (500+ TPS), blocking SELECT FOR UPDATE causes threads to wait 100-500ms when lock contention occurs. This change introduces NOWAIT support for MySQL 8.0+, PostgreSQL, and Oracle, reducing lock contention latency to <1ms by failing fast instead of blocking. Changes: - Add database dialect detection in DataBaseDistributedLocker - Generate NOWAIT SQL for supported databases (MySQL/PostgreSQL/Oracle) - Handle lock-busy exceptions gracefully (return false instead of throw) - Maintain backward compatibility for databases without NOWAIT support - Add configuration switch store.db.distributedLockNoWaitEnabled (default false) - Extend ignoreSQLException to recognize MySQL 3572, PostgreSQL 55P03, Oracle 54 - Add comprehensive unit tests for NOWAIT SQL generation and exception handling Resolves TODO comment at line 150 in DataBaseDistributedLocker. Signed-off-by: sywu14 <wushiyuanwork@outlook.com>
wushiyuanmaimob
force-pushed
the
perf/nowait-distributed-lock
branch
from
0f9176a to
6635e80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the NoWait mechanism for database distributed locks to address issue #7993, resolving the TODO comment at line 150 in
DataBaseDistributedLocker.Problem: Under high concurrency (500+ TPS), the current
SELECT ... FOR UPDATEblocks threads for 100-500ms when lock contention occurs, waiting for database lock timeout.Solution: Introduce
FOR UPDATE NOWAITsupport for MySQL 8.0+, PostgreSQL, and Oracle, reducing lock contention latency to <1ms by failing fast instead of blocking.Changes
MysqlDistributedLockSql,PostgresqlDistributedLockSql, andOracleDistributedLockSqlwith NOWAIT supportgetSelectDistributeForUpdateNoWaitSql()toDistributedLockSqlinterface with default fallbackstore.db.distributedLockNoWaitEnabled(defaultfalse) for opt-in activationignoreSQLException()to recognize:Test Plan
dbCaseEnabled=trueConfiguration
To enable NOWAIT on supported databases, add to
application.yml:Note: Only enable on MySQL 8.0+, PostgreSQL, or Oracle. MySQL 5.x/MariaDB do not support NOWAIT and will raise syntax errors if enabled.
Related Issue
Resolves #7993
🤖 Generated with Claude Code