Skip to content

AWS, Core, Flink, Parquet: Remove deprecations for 1.10.0 #12909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amogh-jahagirdar merged 7 commits into from
May 7, 2025
Merged

AWS, Core, Flink, Parquet: Remove deprecations for 1.10.0 #12909

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
07d2476
Core: Remove deprecated RemoveSnapshot
manuzhang Apr 28, 2025
1ed8765
Remove unused classes and methods
manuzhang Apr 28, 2025
f2173ff
Remove deprecated constructor of GenericManifestFile
manuzhang Apr 28, 2025
46b8791
Address comments
manuzhang Apr 30, 2025
5b19096
Fix Flink UT
manuzhang Apr 30, 2025
1795f43
Remove FileRewriter
manuzhang May 7, 2025
058d997
Redo revapi
manuzhang May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
131 changes: 131 additions & 0 deletions .palantir/revapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,6 +1253,137 @@ acceptedBreaks:
old: "method void org.apache.iceberg.data.parquet.BaseParquetWriter<T>::<init>()"
new: "method void org.apache.iceberg.data.parquet.BaseParquetWriter<T>::<init>()"
justification: "Changing deprecated code"
"1.9.0":
Comment thread
manuzhang marked this conversation as resolved.
Comment thread
nastra marked this conversation as resolved.
org.apache.iceberg:iceberg-core:
- code: "java.class.removed"
old: "class org.apache.iceberg.MetadataUpdate.EnableRowLineage"
justification: "Removing deprecations for 1.10.0"
- code: "java.class.removed"
old: "class org.apache.iceberg.MetadataUpdate.RemoveSnapshot"
justification: "Removing deprecations for 1.10.0"
- code: "java.class.removed"
old: "class org.apache.iceberg.actions.SizeBasedDataRewriter"
justification: "Removing deprecations for 1.10.0"
- code: "java.class.removed"
old: "class org.apache.iceberg.actions.SizeBasedFileRewriter<T extends org.apache.iceberg.ContentScanTask<F\
\ extends org.apache.iceberg.ContentFile<F>>, F>"
justification: "Removing deprecations for 1.10.0"
- code: "java.class.removed"
old: "class org.apache.iceberg.actions.SizeBasedPositionDeletesRewriter"
justification: "Removing deprecations for 1.10.0"
- code: "java.class.removed"
old: "interface org.apache.iceberg.actions.FileRewriter<T extends org.apache.iceberg.ContentScanTask<F\
\ extends org.apache.iceberg.ContentFile<F>>, F>"
justification: "Removing deprecations for 1.10.0"
- code: "java.field.removedWithConstant"
old: "field org.apache.iceberg.TableProperties.ROW_LINEAGE"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.parameterTypeChanged"
old: "parameter org.apache.iceberg.io.ImmutableStorageCredential org.apache.iceberg.io.ImmutableStorageCredential::withConfig(===java.util.Map<java.lang.String,\
\ ? extends java.lang.String>===)"
new: "parameter org.apache.iceberg.io.ImmutableStorageCredential org.apache.iceberg.io.ImmutableStorageCredential::withConfig(===org.apache.iceberg.util.SerializableMap<java.lang.String,\
\ java.lang.String>===)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.parameterTypeChanged"
old: "parameter org.apache.iceberg.io.ImmutableStorageCredential.Builder org.apache.iceberg.io.ImmutableStorageCredential.Builder::config(===java.util.Map<java.lang.String,\
\ ? extends java.lang.String>===)"
new: "parameter org.apache.iceberg.io.ImmutableStorageCredential.Builder org.apache.iceberg.io.ImmutableStorageCredential.Builder::config(===org.apache.iceberg.util.SerializableMap<java.lang.String,\
\ java.lang.String>===)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method boolean org.apache.iceberg.TableMetadata::rowLineageEnabled()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method int org.apache.iceberg.actions.RewriteFileGroup::numFiles()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method int org.apache.iceberg.actions.RewritePositionDeletesGroup::numRewrittenDeleteFiles()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method java.util.List<org.apache.iceberg.FileScanTask> org.apache.iceberg.actions.RewriteFileGroup::fileScans()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method java.util.List<org.apache.iceberg.PositionDeletesScanTask> org.apache.iceberg.actions.RewritePositionDeletesGroup::tasks()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method long org.apache.iceberg.PartitionStats::totalRecordCount()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method long org.apache.iceberg.actions.RewriteFileGroup::sizeInBytes()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method long org.apache.iceberg.actions.RewritePositionDeletesGroup::rewrittenBytes()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.TableMetadata.Builder org.apache.iceberg.TableMetadata.Builder::enableRowLineage()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.io.ImmutableStorageCredential.Builder org.apache.iceberg.io.ImmutableStorageCredential.Builder::putAllConfig(java.util.Map<java.lang.String,\
\ ? extends java.lang.String>)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.io.ImmutableStorageCredential.Builder org.apache.iceberg.io.ImmutableStorageCredential.Builder::putConfig(java.lang.String,\
\ java.lang.String)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.io.ImmutableStorageCredential.Builder org.apache.iceberg.io.ImmutableStorageCredential.Builder::putConfig(java.util.Map.Entry<java.lang.String,\
\ ? extends java.lang.String>)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method void org.apache.iceberg.GenericManifestFile::<init>(java.lang.String,\
\ long, int, org.apache.iceberg.ManifestContent, long, long, java.lang.Long,\
\ int, long, int, long, int, long, java.util.List<org.apache.iceberg.ManifestFile.PartitionFieldSummary>,\
\ java.nio.ByteBuffer)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method void org.apache.iceberg.actions.RewriteFileGroup::<init>(org.apache.iceberg.actions.RewriteDataFiles.FileGroupInfo,\
\ java.util.List<org.apache.iceberg.FileScanTask>)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method void org.apache.iceberg.actions.RewritePositionDeletesGroup::<init>(org.apache.iceberg.actions.RewritePositionDeleteFiles.FileGroupInfo,\
\ java.util.List<org.apache.iceberg.PositionDeletesScanTask>)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.returnTypeChangedCovariantly"
old: "method java.util.Map<java.lang.String, java.lang.String> org.apache.iceberg.io.ImmutableStorageCredential::config()"
new: "method org.apache.iceberg.util.SerializableMap<java.lang.String, java.lang.String>\
\ org.apache.iceberg.io.ImmutableStorageCredential::config()"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.returnTypeChangedCovariantly"
old: "method java.util.Map<java.lang.String, java.lang.String> org.apache.iceberg.io.StorageCredential::config()"
new: "method org.apache.iceberg.util.SerializableMap<java.lang.String, java.lang.String>\
\ org.apache.iceberg.io.StorageCredential::config()"
justification: "Removing deprecations for 1.10.0"
org.apache.iceberg:iceberg-parquet:
- code: "java.method.removed"
old: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriter<T>\
\ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::create(org.apache.parquet.schema.MessageType)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
\ org.apache.iceberg.parquet.ParquetValueWriters::recordWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.parquet.ParquetValueReader<T> org.apache.iceberg.data.parquet.InternalReader<T\
\ extends org.apache.iceberg.StructLike>::createStructReader(java.util.List<org.apache.parquet.schema.Type>,\
\ java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>, org.apache.iceberg.types.Types.StructType)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.parquet.ParquetValueReader<org.apache.iceberg.data.Record>\
\ org.apache.iceberg.data.parquet.GenericParquetReaders::createStructReader(java.util.List<org.apache.parquet.schema.Type>,\
\ java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>, org.apache.iceberg.types.Types.StructType)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.parquet.ParquetValueWriter<org.apache.iceberg.data.Record>\
\ org.apache.iceberg.data.parquet.GenericParquetWriter::buildWriter(org.apache.parquet.schema.MessageType)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
\ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::createStructWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
justification: "Removing deprecations for 1.10.0"
- code: "java.method.removed"
old: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<org.apache.iceberg.data.Record>\
\ org.apache.iceberg.data.parquet.GenericParquetWriter::createStructWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
justification: "Removing deprecations for 1.10.0"
apache-iceberg-0.14.0:
org.apache.iceberg:iceberg-api:
- code: "java.class.defaultSerializationChanged"
Expand Down
160 changes: 0 additions & 160 deletions aws/src/main/java/org/apache/iceberg/aws/RESTSigV4Signer.java
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions core/src/main/java/org/apache/iceberg/GenericManifestFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,47 +134,6 @@ public GenericManifestFile(Schema avroSchema) {
this.firstRowId = firstRowId;
}

/**
* GenericManifestFile constructor.
*
* @deprecated will be removed in 1.10.0; use {@link ManifestWriter#toManifestFile()} instead.
*/
@Deprecated
public GenericManifestFile(
String path,
long length,
int specId,
ManifestContent content,
long sequenceNumber,
long minSequenceNumber,
Long snapshotId,
int addedFilesCount,
long addedRowsCount,
int existingFilesCount,
long existingRowsCount,
int deletedFilesCount,
long deletedRowsCount,
List<PartitionFieldSummary> partitions,
ByteBuffer keyMetadata) {
super(ManifestFile.schema().columns().size());
this.avroSchema = AVRO_SCHEMA;
this.manifestPath = path;
this.length = length;
this.specId = specId;
this.content = content;
this.sequenceNumber = sequenceNumber;
this.minSequenceNumber = minSequenceNumber;
this.snapshotId = snapshotId;
this.addedFilesCount = addedFilesCount;
this.addedRowsCount = addedRowsCount;
this.existingFilesCount = existingFilesCount;
this.existingRowsCount = existingRowsCount;
this.deletedFilesCount = deletedFilesCount;
this.deletedRowsCount = deletedRowsCount;
this.partitions = partitions == null ? null : partitions.toArray(new PartitionFieldSummary[0]);
this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
}

/**
* Copy constructor.
*
Expand Down
Loading
Loading