GROOVY-11978: RootLoader duplicates the core jar already on the boots…#2504
Merged
paulk-asert merged 1 commit intoapache:masterfrom May 2, 2026
Merged
GROOVY-11978: RootLoader duplicates the core jar already on the boots…#2504paulk-asert merged 1 commit intoapache:masterfrom
paulk-asert merged 1 commit intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2504 +/- ##
==================================================
- Coverage 67.2264% 67.2223% -0.0041%
- Complexity 31984 31987 +3
==================================================
Files 1468 1468
Lines 123923 123944 +21
Branches 22251 22258 +7
==================================================
+ Hits 83309 83318 +9
- Misses 33433 33439 +6
- Partials 7181 7187 +6
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Addresses GROOVY-11978 by preventing RootLoader from re-adding core Groovy JARs that are already present on the JVM’s startup classpath, avoiding duplicate class/resource definitions.
Changes:
- Compute a canonicalized set of files from
java.class.path. - Skip adding
LoaderConfigurationURLs that resolve to files already present on that startup classpath. - Add helper methods to canonicalize
URL/Fileentries for reliable comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…trap classpath
https://issues.apache.org/jira/browse/GROOVY-11978