[Cherry-pick to branch-1.2] [MINOR] fix(mcp-server): URL-encode path segments in MCP REST client (#10799)#10806
Open
github-actions[bot] wants to merge 1 commit intobranch-1.2from
Open
Conversation
…10799) ### What changes were proposed in this pull request? Add a `encode_path_segment()` helper in `utils.py` using `urllib.parse.quote(segment, safe="")` and apply it to every user-supplied identifier embedded in URL paths across all plain REST client operation classes (`catalog`, `schema`, `table`, `model`, `topic`, `fileset`, `tag`, `job`, `policy`, `statistic`). Query parameters previously concatenated into f-strings are moved to the httpx `params=` argument. Also adds 29 unit tests covering various special-character inputs for all affected operation classes. ### Why are the changes needed? User-supplied identifiers (metalake name, catalog name, schema name, table name, etc.) were concatenated directly into URL paths using f-strings without encoding. Characters like `/`, `?`, `#`, and `%` in resource names could alter the intended request target, causing unexpected behavior. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added 29 unit tests in `tests/unit/client/test_url_encoding.py` that pass special-character inputs into every affected operation method and assert the encoded form appears in the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick Information:
branch-1.2