Skip to content

[Flink-39425] [flink-metrics-otel] OpenTelemetryEventReporter logger fix for missing service.name#27966

Open
SameerDevgon wants to merge 2 commits intoapache:masterfrom
SameerDevgon:FLINK-39425-otel-improvement
Open

[Flink-39425] [flink-metrics-otel] OpenTelemetryEventReporter logger fix for missing service.name#27966
SameerDevgon wants to merge 2 commits intoapache:masterfrom
SameerDevgon:FLINK-39425-otel-improvement

Conversation

@SameerDevgon
Copy link
Copy Markdown

What is the purpose of the change

OpenTelemetryEventReporter logger has a missing init method call this means the service.name and service.version config options, defined in OpenTelemetryReporterOptions, are silently ignored for the event reporter. The resource field in OpenTelemetryReporterBase remains as Resource.getDefault() (which sets service.name = unknown_service:java), and that default is then baked into the SdkLoggerProvider at construction time.

Brief change log

  • OpenTelemetryEventReporter call to super method of OpenTelemetryReporterBase that will merge the resource config (service.name)

Verifying this change

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for validating service.name is correctly added into logs
  • Added unit test that validates the loggers to have the resource service.name value

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 18, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@spuru9
Copy link
Copy Markdown
Contributor

spuru9 commented Apr 18, 2026

cc: @paras-negi-flink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants