Skip to content

[FLINK-39481][tests] Fix flaky WindowDistinctAggregateITCase#testCumulateWindow_GroupingSets #27954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
featzhang wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −7
Open

[FLINK-39481][tests] Fix flaky WindowDistinctAggregateITCase#testCumulateWindow_GroupingSets #27954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...r/src/test/java/org/apache/flink/table/planner/runtime/utils/FailingCollectionSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ public class FailingCollectionSource<T>
/** A failure will occur when the given number of elements have been processed. */
private final int failureAfterNumElements;

/** The number of completed checkpoints. */
private volatile int numSuccessfulCheckpoints;

/** The checkpointed number of emitted elements. */
private final Map<Long, Integer> checkpointedEmittedNums;

Expand Down Expand Up @@ -166,9 +163,8 @@ public void run(SourceContext<T> ctx) throws Exception {
if (!failedBefore) {
// delay a bit, if we have not failed before
Thread.sleep(1);
if (numSuccessfulCheckpoints >= 1 && lastCheckpointedEmittedNum >= 1) {
// cause a failure if we have not failed before and have a completed checkpoint
// and have processed at least one element
if (lastCheckpointedEmittedNum >= failureAfterNumElements) {
// trigger failure after enough elements are durably checkpointed
failedBefore = true;
throw new Exception("Artificial Failure");
}
Expand Down Expand Up @@ -238,7 +234,6 @@ public void snapshotState(FunctionSnapshotContext context) throws Exception {

@Override
public void notifyCheckpointComplete(long checkpointId) throws Exception {
numSuccessfulCheckpoints++;
lastCheckpointedEmittedNum = checkpointedEmittedNums.get(checkpointId);
}

Expand Down