Skip to content

[FLINK-39414] TaskExecutorPartitionLifecycleTest#testEnableBatchJobRecoveryAnd* take long time to complete#27930

Open
HundalTaran wants to merge 3 commits intoapache:masterfrom
coder1592084:issue39414
Open

[FLINK-39414] TaskExecutorPartitionLifecycleTest#testEnableBatchJobRecoveryAnd* take long time to complete#27930
HundalTaran wants to merge 3 commits intoapache:masterfrom
coder1592084:issue39414

Conversation

@HundalTaran
Copy link
Copy Markdown
Contributor

What is the purpose of the change

There are two test methods in TaskExecutorPartitionLifecycleTest which take quite long to finish:
testEnableBatchJobRecoveryAndNotRetainPartitions takes 15s
testEnableBatchJobRecoveryAndRetainPartitions takes 30s

Brief change log

Issue is each test depends on the duration and longDuration fields which can be reduced dramatically. The test just needs to prove a future doesn't completewithin a window — it doesn't need 15s/30s for that.
So reduced the duration to 200ms and 300ms respectively.
private Duration duration = Duration.ofMillis(200);
private Duration longDuration = Duration.ofMillis(300);

Verifying this change

The changes are verified by running this test class multiple times.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) - no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) - no
  • The serializers: (yes / no / don't know) - no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) - no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) - no
  • The S3 file system connector: (yes / no / don't know) - no

Documentation

  • Does this pull request introduce a new feature? (yes / no) - no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) - no

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 15, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@spuru9 spuru9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HundalTaran Can you add the Jira ID to the PR [FLINK-39414] in place of Issue.
Help in linking up.

@HundalTaran HundalTaran changed the title [Issue39414] TaskExecutorPartitionLifecycleTest#testEnableBatchJobRecoveryAnd* take long time to complete [Flink-39414] TaskExecutorPartitionLifecycleTest#testEnableBatchJobRecoveryAnd* take long time to complete Apr 15, 2026
@HundalTaran
Copy link
Copy Markdown
Contributor Author

HundalTaran commented Apr 15, 2026

@HundalTaran Can you add the Jira ID to the PR [FLINK-39414] in place of Issue. Help in linking up.

Thanks made the changes

@HundalTaran
Copy link
Copy Markdown
Contributor Author

CI report:

Bot commands

I have checked the logs, it does not seems like that failure is due to my changes:

failure reason: 2026-04-15T06:57:58.6124653Z Apr 15 06:57:58 06:57:58.607 [INFO] ------------------------------------------------------------------------
2026-04-15T06:57:58.6125584Z Apr 15 06:57:58 06:57:58.607 [WARNING] The requested profile "skip-webui-build" could not be activated because it does not exist.
2026-04-15T06:57:58.6127751Z Apr 15 06:57:58 06:57:58.608 [ERROR] Failed to execute goal on project flink-hadoop-fs: Could not resolve dependencies for project org.apache.flink:flink-hadoop-fs:jar:2.3-SNAPSHOT: Could not transfer artifact org.apache.hadoop:hadoop-hdfs:jar:2.10.2 from/to google-maven-central (https://maven-central-eu.storage-download.googleapis.com/maven2/): GET request of: org/apache/hadoop/hadoop-hdfs/2.10.2/hadoop-hdfs-2.10.2.jar from google-maven-central failed: Premature end of Content-Length delimited message body (expected: 5,208,710; received: 524,288) -> [Help 1]

@HundalTaran
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@HundalTaran HundalTaran changed the title [Flink-39414] TaskExecutorPartitionLifecycleTest#testEnableBatchJobRecoveryAnd* take long time to complete [FLINK-39414] TaskExecutorPartitionLifecycleTest#testEnableBatchJobRecoveryAnd* take long time to complete Apr 15, 2026
@spuru9
Copy link
Copy Markdown
Contributor

spuru9 commented Apr 15, 2026

Sorry for a followup query
I notice the file mode have been changed? Was it intended

  • 100644 = normal file (rw-r--r--)
  • 100755 = executable file (rwxr-xr-x)
image

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Apr 15, 2026
@HundalTaran
Copy link
Copy Markdown
Contributor Author

Sorry for a followup query I notice the file mode have been changed? Was it intended

  • 100644 = normal file (rw-r--r--)
  • 100755 = executable file (rwxr-xr-x)
image

No issues, and your question is absolutely valid. But it was not intended at all to change the file permission and I have not changed it. It just that this time I am using windows system to push the code, may be that is why this happened.
Logical explanation:
If you are on Windows or using a file system that does not handle Unix permissions correctly (like FAT32/ExFAT), Git may falsely report permission changes.

But still trying to fix this. Thanks for bringing this up for me to notice it.

@HundalTaran HundalTaran force-pushed the issue39414 branch 2 times, most recently from e8ffe12 to 96db245 Compare April 15, 2026 09:32
Copy link
Copy Markdown
Contributor

@spuru9 spuru9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change.
LGTM +1

@HundalTaran
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

1 similar comment
@HundalTaran
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@HundalTaran
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants