fix: avoid panic in date_bin compute_distance near i64::MIN#22408
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
date_binpanics withattempt to subtract with overflowwhen the source timestamp sits neari64::MINbecausecompute_distancedoestime_diff - (time_diff % stride)and thentime_delta - strideon rawi64. The scalar pipeline already mapsErrfrombin_fnintoNULL, so the fix is to surface the overflow as a normal error.What changes are included in this PR?
compute_distanceto returnResult<i64>and usechecked_sub.date_bin_nanos_intervalanddate_bin_months_interval, plus replace the trailingorigin + time_deltawithchecked_add.Are these changes tested?
Yes. Added
test_date_bin_compute_distance_i64_minwhich previously panicked and now returnsNULL. Rancargo test -p datafusion-functions --lib -- datetime::date_bin,cargo fmt --check, andcargo clippy -p datafusion-functions --lib --tests --no-deps.Are there any user-facing changes?
Queries that previously panicked on extreme timestamps now return
NULL(consistent with the existing out-of-range behavior covered bytest_date_bin_out_of_range).