-
Notifications
You must be signed in to change notification settings - Fork 2.1k
PushdownFilter optimizations #21668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PushdownFilter optimizations #21668
Changes from all commits
838ab84
e615f63
587292a
6323386
02cf97d
8c2db0d
4b44591
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2495,6 +2495,19 @@ pub struct Filter { | |
| } | ||
|
|
||
| impl Filter { | ||
| /// Create a new filter operator. | ||
| /// | ||
| /// Skips the type-checking and dealiasing done in [Self::try_new]. | ||
| /// For internal use in DataFusion only. | ||
| /// | ||
| /// **Preconditions:** | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| /// - the `predicate` expression returns a boolean value | ||
| /// - the `predicate` expression is not aliased | ||
| #[doc(hidden)] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about just call this Though it does have the same properties that the the caller needs to ensure some invariants Could you please document what the properties are? I think
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I named it |
||
| pub fn new(predicate: Expr, input: Arc<LogicalPlan>) -> Self { | ||
| Self { predicate, input } | ||
| } | ||
|
|
||
| /// Create a new filter operator. | ||
| /// | ||
| /// Notes: as Aliases have no effect on the output of a filter operator, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this change as a separate PR to datafusion-testing first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apache/datafusion-testing#20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged