Skip to content

Update rust vesion to 1.57 #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 5 commits into from
Dec 4, 2021
Merged

Update rust vesion to 1.57 #1395

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30dd9c9
Update rust vesion to 1.57
xudong963 Dec 3, 2021
f17bb24
Clean ups related to clippy
alamb Dec 3, 2021
bfc372c
remove more unused fields
alamb Dec 3, 2021
31e6db8
Remove some more unused code
alamb Dec 3, 2021
4c8b337
remove data_type from Average, but keep in consutrctor
alamb Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ballista/rust/executor/src/flight_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ type FlightDataReceiver = Receiver<Result<FlightData, Status>>;
#[derive(Clone)]
pub struct BallistaFlightService {
/// Executor
executor: Arc<Executor>,
_executor: Arc<Executor>,
}

impl BallistaFlightService {
pub fn new(executor: Arc<Executor>) -> Self {
Self { executor }
pub fn new(_executor: Arc<Executor>) -> Self {
Self { _executor }
}
}

Expand Down
14 changes: 6 additions & 8 deletions benchmarks/src/bin/tpch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,9 @@ struct BallistaBenchmarkOpt {
#[structopt(short = "i", long = "iterations", default_value = "3")]
iterations: usize,

/// Batch size when reading CSV or Parquet files
#[structopt(short = "s", long = "batch-size", default_value = "8192")]
batch_size: usize,

// /// Batch size when reading CSV or Parquet files
Copy link
Copy Markdown
Contributor

@alamb alamb Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These parameters are never read (aka they don't do anything) so removing them from the CLI seemed like a reasonable thing to do

// #[structopt(short = "s", long = "batch-size", default_value = "8192")]
// batch_size: usize,
/// Path to data files
#[structopt(parse(from_os_str), required = true, short = "p", long = "path")]
path: PathBuf,
Expand All @@ -87,10 +86,9 @@ struct BallistaBenchmarkOpt {
#[structopt(short = "f", long = "format", default_value = "csv")]
file_format: String,

/// Load the data into a MemTable before executing the query
#[structopt(short = "m", long = "mem-table")]
mem_table: bool,

// /// Load the data into a MemTable before executing the query
// #[structopt(short = "m", long = "mem-table")]
// mem_table: bool,
/// Number of partitions to process in parallel
#[structopt(short = "p", long = "partitions", default_value = "2")]
partitions: usize,
Expand Down