PostgreSQL UNLOGGED Table Support and ALTER TABLE ... SET LOGGED|UNLOGGED#2251
Open
LucaCappelletti94 wants to merge 5 commits intoapache:mainfrom
Open
PostgreSQL UNLOGGED Table Support and ALTER TABLE ... SET LOGGED|UNLOGGED#2251LucaCappelletti94 wants to merge 5 commits intoapache:mainfrom
UNLOGGED Table Support and ALTER TABLE ... SET LOGGED|UNLOGGED#2251LucaCappelletti94 wants to merge 5 commits intoapache:mainfrom
Conversation
iffyio
reviewed
Mar 4, 2026
Add parser and AST support for PostgreSQL CREATE UNLOGGED TABLE and\nALTER TABLE ... SET LOGGED|UNLOGGED operations.\n\n- add LOGGED keyword\n- add CreateTable.unlogged and wire it through CreateTableBuilder\n- render UNLOGGED in CreateTable display\n- add AlterTableOperation::SetLogged and ::SetUnlogged display/spans\n- parse UNLOGGED only for PostgreSqlDialect|GenericDialect\n- parse ALTER TABLE SET LOGGED|UNLOGGED operations
Add PostgreSQL regression coverage for the new syntax support and\nupdate existing struct-literal CreateTable expectations with the\nnew unlogged field in cross-dialect tests.\n\n- add parse_create_unlogged_table\n- add parse_alter_table_set_logged_unlogged\n- set unlogged defaults in duckdb/mssql fixture assertions
LucaCappelletti94
force-pushed
the
postgres-regression-6
branch
from
cffc8bb to
2a6609b
Compare
iffyio
reviewed
Apr 21, 2026
Comment on lines
+5121
to
+5122
| } else if unlogged { | ||
| self.expected_ref("TABLE after UNLOGGED", self.peek_token_ref()) |
Contributor
There was a problem hiding this comment.
I think this shouldn't be needed, the else branch covers the scenario where there is no match?
Comment on lines
+5111
to
+5112
| let unlogged = dialect_of!(self is PostgreSqlDialect | GenericDialect) | ||
| && self.parse_keyword(Keyword::UNLOGGED); |
Contributor
There was a problem hiding this comment.
is there a requirement to use a dialect guard? if not we can always accept the syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds parser and AST support for PostgreSQL table logging controls:
CREATE UNLOGGED TABLE ...ALTER TABLE ... SET LOGGEDALTER TABLE ... SET UNLOGGEDIt also adds regression tests and updates cross-dialect test fixtures impacted by the AST shape change.