Ensure that all application/json responses are parsed as JSON#368
Merged
Ensure that all application/json responses are parsed as JSON#368
Conversation
…racter set are parsed as JSON. Fixes issue #366
big-r81
reviewed
Apr 1, 2026
| if (req.method === 'head') { | ||
| retval = Object.fromEntries(response.headers) | ||
| } else if (contentType === 'application/json') { | ||
| } else if (contentType && contentType.startsWith('application/json')) { |
Contributor
There was a problem hiding this comment.
Short question: Are these headers always trimmed before?
Contributor
Author
There was a problem hiding this comment.
I've just checked, and they are not! 🫤
Contributor
Author
There was a problem hiding this comment.
I'm not going to worry about it just now.
janl
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Issue #366 reported that a content-type of
application/json; charset=utf-8was not being parsed as json. This PR fixes that.Testing recommendations
Automated test added to try a content-type with a charset.
GitHub issue number
Fixes issue #366.
Related Pull Requests
n/a
Checklist