CASSSIDECAR-465: Improve HTTP 429 handling across sidecar server and … - #374
Draft
arjunashok wants to merge 1 commit into
Draft
CASSSIDECAR-465: Improve HTTP 429 handling across sidecar server and …#374arjunashok wants to merge 1 commit into
arjunashok wants to merge 1 commit into
Conversation
…client Patch by Arjun Ashok for CASSSIDECAR-465
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…client
Changes
BasicRetryPolicyhad no case for it. As a result, clients failed after one attempt instead of backing off.BasicRetryPolicy(honorsRetry-After, falls back to configured backoff); fixes a prerequisite bug inRequestExecutor.schedule()that fired retries immediately instead of waiting (this was silently breaking the existing 503 backoff too, independent of 429); adds aRetry-Afterheader to the server's 429 response, via config:retry_after_seconds.retryAfterSeconds()is adefaultinterface method for backward compatibility