Codemirror and Add Application Wization enhancements - #5
Merged
Conversation
from commit 50c82bccf70a19fd4add99542dfdf06a60280da8 (today) with parse listener enhancement nodeca/js-yaml#249
…utton takes you to composer previously "preview" button just reset the dialog; this also gives slightly more interesting examples
…"Finish" and the "Open in Composer" button is highlighted if you pick a template
and allow "Open in Composer" for normal items, not just templates
also adjust height w custom codemirror styling
This was referenced Feb 16, 2016
Member
|
LGTM |
tommclaughlan
pushed a commit
to diffusiondata/brooklyn-ui
that referenced
this pull request
Jan 18, 2018
asfgit
pushed a commit
that referenced
this pull request
Nov 16, 2021
Proper state change for all delete cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the issues described at #1
it's now rather pleasurable to use the yaml editor, and the flow from the wizard to the composer to the catalog and back seems smooth to me
thanks @tbouron and @Hellberg for the ui advice on codemirror, it acts almost as a tutor for the different modes (although it would be nice to find a way to make the distinctions even clearer)