Skip to content

regenerate requirements and tweak versions based on prior or proposed changes#38358

Closed
derrickaw wants to merge 4 commits intoapache:masterfrom
derrickaw:20260430_updatePythonVersions
Closed

regenerate requirements and tweak versions based on prior or proposed changes#38358
derrickaw wants to merge 4 commits intoapache:masterfrom
derrickaw:20260430_updatePythonVersions

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

@derrickaw derrickaw commented May 1, 2026

  1. Some previous recent PRs updated the generated base requirements and got out of step with the setup.py and others. This tries to fix those recent changes.
  2. Addresses Update jinja2 requirement from <4.0.0,>=2.7.1 to >=3.0.3,<4.0.0 in /sdks/python #38351, Update pyyaml requirement from <7.0.0,>=3.12 to >=5.4.1,<7.0.0 in /sdks/python #38352 that also require additional changes.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@derrickaw derrickaw force-pushed the 20260430_updatePythonVersions branch from ec3887f to ed82509 Compare May 1, 2026 20:21
@derrickaw derrickaw marked this pull request as ready for review May 3, 2026 03:52
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on aligning the Python SDK's dependency requirements with recent changes and proposed updates. By synchronizing these versions across multiple configuration files, the changes ensure that the environment remains stable and compatible with the latest project requirements, while also addressing specific versioning needs identified in related pull requests.

Highlights

  • Dependency Synchronization: Synchronized base requirements and setup configurations to ensure consistency across the project.
  • Version Updates: Updated various Python package versions, including core libraries like aiohttp, build, cryptography, and pytest to align with recent changes and proposed requirements.
  • Configuration Adjustments: Updated pyproject.toml and build.gradle to reflect new version constraints for Jinja2 and PyYAML.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a large-scale update of dependency versions across multiple Python environments and container images, including google-adk, opentelemetry, and pytest. Feedback highlights several version mismatches between setup.py and the frozen requirements files, specifically for opentelemetry and torch. Additionally, the reviewer flagged inconsistent downgrades for keras, torch (GPU), and xgrammar in specific environment configurations, suggesting these should be aligned with the upgrades applied elsewhere in the project.

Comment thread sdks/python/setup.py
Comment thread sdks/python/setup.py Outdated
Comment thread sdks/python/setup.py Outdated
Comment thread sdks/python/container/ml/py310/base_image_requirements.txt
Comment thread sdks/python/container/ml/py312/gpu_image_requirements.txt
Comment thread sdks/python/container/ml/py312/gpu_image_requirements.txt
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

Assigning reviewers:

R: @jrmccluskey for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw derrickaw closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant