[v3-2-test] UI: Fix log line number gaps caused by group markers (#65039)#65183
Closed
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Closed
[v3-2-test] UI: Fix log line number gaps caused by group markers (#65039)#65183github-actions[bot] wants to merge 1 commit intov3-2-testfrom
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Conversation
) * Fix log line number gaps caused by group markers (#47888) Group markers (::group:: / ::endgroup::) consumed line number indices but were removed during group processing, leaving gaps in the displayed line numbers (e.g. 0, 2, 3 instead of 0, 1, 2). Pre-scan the log data to assign sequential display line numbers that skip group markers, and pin wrapped line numbers to the top with alignItems flex-start. * fix test --------- (cherry picked from commit 55162a3) Co-authored-by: Daniel Seo <dseo1004@gmail.com> Co-authored-by: hseo36 <hseo36@bloomberg.net>
1 task
bbovenzi
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
bbovenzi
approved these changes
Apr 13, 2026
This was referenced Apr 14, 2026
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Closing in favor of #65187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group markers (::group:: / ::endgroup::) consumed line number indices
but were removed during group processing, leaving gaps in the displayed
line numbers (e.g. 0, 2, 3 instead of 0, 1, 2).
Pre-scan the log data to assign sequential display line numbers that
skip group markers, and pin wrapped line numbers to the top with
alignItems flex-start.
(cherry picked from commit 55162a3)
Co-authored-by: Daniel Seo dseo1004@gmail.com
Co-authored-by: hseo36 hseo36@bloomberg.net