Skip to content

fix(amazon): extend SQS QUEUE_REGEXP to match AWS China endpoints #65173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Apr 14, 2026
+6 −1
Merged

fix(amazon): extend SQS QUEUE_REGEXP to match AWS China endpoints #65173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/amazon/src/airflow/providers/amazon/aws/queues/sqs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
from airflow.triggers.base import BaseEventTrigger

# [START queue_regexp]
QUEUE_REGEXP = r"^https://sqs\.[^.]+\.amazonaws\.com/[0-9]+/.+"
QUEUE_REGEXP = r"^https://sqs\.[^.]+\.(amazonaws\.com|amazonaws\.cn)/[0-9]+/.+"
# [END queue_regexp]


Expand Down
5 changes: 5 additions & 0 deletions providers/amazon/tests/unit/amazon/aws/queues/test_sqs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,15 @@ def test_message_sqs_queue_matches():
from airflow.providers.amazon.aws.queues.sqs import SqsMessageQueueProvider

provider = SqsMessageQueueProvider()
# Standard AWS regions
assert provider.queue_matches("https://sqs.us-east-1.amazonaws.com/123456789012/my-queue")
assert not provider.queue_matches("https://sqs.us-east-1.amazonaws.com/123456789012")
assert not provider.queue_matches("https://sqs.us-east-1.amazonaws.com/123456789012/")
assert not provider.queue_matches("https://sqs.us-east-1.amazonaws.com/")
# AWS China regions (cn-north-1, cn-northwest-1)
assert provider.queue_matches("https://sqs.cn-north-1.amazonaws.cn/123456789012/my-queue")
assert provider.queue_matches("https://sqs.cn-northwest-1.amazonaws.cn/123456789012/my-queue")
assert not provider.queue_matches("https://sqs.cn-north-1.amazonaws.cn/123456789012")


@pytest.mark.parametrize(
Expand Down
Loading