[v3-2-test] Add fast-path heartbeat UPDATE to avoid row lock in the common case (#65029)#65137
Open
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Open
[v3-2-test] Add fast-path heartbeat UPDATE to avoid row lock in the common case (#65029)#65137github-actions[bot] wants to merge 1 commit intov3-2-testfrom
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Conversation
…ommon case (#65029) * Add fast-path heartbeat UPDATE to avoid row lock in the common case The ti_heartbeat endpoint now attempts a single guarded UPDATE (matching id, state, hostname, and pid) before falling back to the existing SELECT FOR UPDATE path. When the task is still running on the expected host this returns immediately, eliminating the row lock and a round trip for the vast majority of heartbeat calls. * fixup! Add fast-path heartbeat UPDATE to avoid row lock in the common case * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix static checks * fixup! Fix static checks --------- (cherry picked from commit c97d1a5) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ti_heartbeat endpoint now attempts a single guarded UPDATE
(matching id, state, hostname, and pid) before falling back to the
existing SELECT FOR UPDATE path. When the task is still running on
the expected host this returns immediately, eliminating the row lock
and a round trip for the vast majority of heartbeat calls.
fixup! Add fast-path heartbeat UPDATE to avoid row lock in the common case
Apply suggestions from code review
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com
Fix static checks
fixup! Fix static checks
(cherry picked from commit c97d1a5)
Co-authored-by: Ephraim Anierobi splendidzigy24@gmail.com
Co-authored-by: Copilot 175728472+Copilot@users.noreply.github.com