Skip to content

Fix - test_syscall_get_sysvar#5161

Merged
Lichtso merged 2 commits into
anza-xyz:masterfrom
Lichtso:fix/test_syscall_get_sysvar
Mar 6, 2025
Merged

Fix - test_syscall_get_sysvar#5161
Lichtso merged 2 commits into
anza-xyz:masterfrom
Lichtso:fix/test_syscall_get_sysvar

Conversation

@Lichtso
Copy link
Copy Markdown

@Lichtso Lichtso commented Mar 5, 2025

Problem

An incorrect test setup lead to failures in the CI, which got triggered by #5155.

Summary of Changes

Moves temporary Pubkeys into surrounding scope to pin MemoryMapping.

@Lichtso Lichtso requested a review from alexpyattaev March 5, 2025 22:16
@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 5, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso requested a review from LucasSte March 5, 2025 22:23
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lichtso Lichtso marked this pull request as ready for review March 5, 2025 23:28
@Lichtso Lichtso requested a review from a team as a code owner March 5, 2025 23:28
@Lichtso Lichtso merged commit 3ad2880 into anza-xyz:master Mar 6, 2025
@Lichtso Lichtso deleted the fix/test_syscall_get_sysvar branch March 6, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants