Skip redundant cost limit update in banking-bench#4079
Merged
Conversation
apfitzge
approved these changes
Dec 12, 2024
apfitzge
left a comment
apfitzge
left a comment
There was a problem hiding this comment.
A purely red PR gets the greenlight from me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
as cost limit inheriting was sneaked in #2733 by me, banking-bench is currently needlessly setting the bank cost limits to max repeatedly inside the loop.
the bench is doing it already before the loop and it's enough by now.
Summary of Changes
Remove the redundant setting in banking-stage.
extracted from #3946, see the pr for the general overview.