Skip to content

fix(useFiles): stop warning on expected evicted-media reads #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pasumarthi Rutwik (rutwik2001) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(useFiles): stop warning on expected evicted-media reads #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/react/useFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,14 +572,23 @@ export function useFiles(options: UseFilesOptions): UseFilesResult {
try {
const encryptionKey = await getEncryptionKey(walletAddress);
const result = await readEncryptedFile(mediaId, encryptionKey);
if (!result) {
throw new Error(`File could not be found: ${mediaId}`);
if (result) {
return new File([result.blob], result.metadata?.name || mediaId, {
type: result.metadata?.type || "application/octet-stream",
});
}
return new File([result.blob], result.metadata?.name || mediaId, {
type: result.metadata?.type || "application/octet-stream",
});
// result === null means the encrypted bytes simply aren't on this
// device: the file was evicted off-device, or synced as metadata but
// never pulled. This is an EXPECTED state once media eviction / backup
// restore is in play — the caller resolves it via backup-first restore
// (e.g. EvictedMediaTile / downloadEvictedMedia). Log at debug so it
// stays traceable without spamming warn on every evicted read.
getLogger().debug(
`[useFiles] No local encrypted bytes for ${mediaId} (likely evicted), trying legacy storage`
);
} catch (encryptedError) {
// If encrypted read fails, fall back to legacy storage
// A real failure (decrypt error, IO error) — keep it at warn so it
// surfaces, since this is not the expected "not present" path.
getLogger().warn(
`[useFiles] Encrypted read failed for ${mediaId}, trying legacy storage`,
encryptedError
Expand Down
Loading