Feature: unified semantic-dom title in the docs#1877
Open
Rain120 wants to merge 14 commits into
Open
Conversation
Contributor
|
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthrough将若干中文文档章节标题由“语义化 DOM”统一改为英文 “Semantic DOM”，并将 packages/x-skill/src/skill-meta.json 中六个技能的版本从 2.5.0 升级至 2.6.0，同时调整部分技能的 tags 配置。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request translates "语义化 DOM" to "Semantic DOM" in documentation and updates versions and tags in skill-meta.json. Feedback suggests that the changes to skill-meta.json are out of scope and reduce metadata granularity. Additionally, renaming multiple headers to "Semantic DOM" in API.md creates duplicate anchors that may break documentation navigation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/x-skill/skills-zh/x-components/reference/API.md`:
- Line 811: 当前文件中存在重复的同级标题 "## Semantic DOM"（触发
MD024/no-duplicate-heading）；请在重复的标题处将其中一个改为唯一化（例如改为 "## Semantic DOM — <组件名>" 或
"### Semantic DOM"
以改变层级），并同步更新任何引用该标题的锚点或链接（检查文档内的跳转/目录引用）；确保保留语义并在标题文本中加入组件前缀或其它区分信息以避免再次重复。
In `@packages/x-skill/src/skill-meta.json`:
- Line 20: 当前问题是 skill 元数据里的领域标签被覆盖为仅 ["sdk"]，导致检索召回精度下降；在生成元信息的逻辑（参见
generate-meta.ts）应保留并合并输入 metadata 中的 tags 而不是只按名称生成通用标签。请修改 generate-meta.ts
中构建 tags 的处所（例如处理 skill-meta.json 的生成函数）以：1) 读取原始 input.metadata.tags（若存在），2) 与按
name 生成的默认标签合并，3) 去重并保证顺序稳定，最后写回 skill-meta.json；并把相同处理应用到其他受影响的生成逻辑以修复
x-card/x-components/x-markdown 等。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d1aff391-5a40-45c9-a420-5d8ca6ebe462
📒 Files selected for processing (4)
packages/x-skill/skills-zh/x-components/reference/API.mdpackages/x-skill/src/skill-meta.jsonpackages/x/components/file-card/index.zh-CN.mdpackages/x/components/folder/index.zh-CN.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 158 158
Lines 5505 5505
Branches 1610 1611 +1
=======================================
Hits 5366 5366
Misses 137 137
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 1.48MB (40.51%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: x-markdown-array-pushAssets Changed:
view changes for bundle: antdx-array-pushAssets Changed:
|
afc163
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Unified semantic-dom title in the Chinese docs
💡 Background and Solution
Background
All of the Chinese docs are named 'Semantic DOM', but file-card and folder are special
Solution
Make them unified to be 'Semantic DOM'.
Summary by CodeRabbit
发布说明
文档
Chores
agent标签并将若干组件标签统一为sdk。