fix(opencode): support macOS cmd+v image paste in tui#22197
Open
hernandezsanti wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): support macOS cmd+v image paste in tui#22197hernandezsanti wants to merge 1 commit intoanomalyco:devfrom
hernandezsanti wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22194
Type of change
What does this PR do?
On macOS, clipboard image paste in the TUI only worked reliably through the existing
input_pastepath, socmd+vcould miss image attachments depending on the terminal.This change adds a small
probePaste()helper for macOScmd+v, reuses one clipboard attachment path for both keydown and empty paste events, and avoids double-attaching when the key event and paste event happen back-to-back.It works because image attachment now happens through the same code path whether the terminal reports paste as
ctrl+v,meta/super+v, or an empty paste event.How did you verify your code works?
bun test test/cli/cmd/tui/paste-key.test.tsbun run typecheckcmd+v, and confirmed the image attached in the promptScreenshots / recordings
N/A for this bug fix.
Checklist