fix(opencode): Duplicated user request during ACP use#22192
Closed
OpeOginni wants to merge 2 commits intoanomalyco:devfrom
Closed
fix(opencode): Duplicated user request during ACP use#22192OpeOginni wants to merge 2 commits intoanomalyco:devfrom
OpeOginni wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: PR #21851: "fix(acp): stop emitting user_message_chunk during session/prompt turn" This appears to be directly related to the current PR #22192. Both address the same issue of not emitting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21910
Type of change
What does this PR do?
fixes an ACP integration bug where OpenCode echoed the user’s live prompt back to the editor as user_message_chunk. We don’t need to send user_message_chunk for a live prompt because the client already has that message
How did you verify your code works?
Created a Custom ACP server with my dev opencode instance and tested this agent and noticed no duplicated user request.
Screenshots / recordings
Checklist