fix(app): allow selecting root in project picker#22140
Open
SubLoadedZA wants to merge 1 commit intoanomalyco:devfrom
Open
fix(app): allow selecting root in project picker#22140SubLoadedZA wants to merge 1 commit intoanomalyco:devfrom
SubLoadedZA wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21698
Type of change
What does this PR do?
When opening the project picker in the web UI and typing
/, root was not reliably selectable as a workspace.This change updates the directory suggestion base logic in
packages/app/src/components/dialog-select-directory.tsxso the base directory is included for both:~paths (existing behavior)/(new behavior)This works because the picker now keeps the scoped absolute root in the candidate set, so
/itself appears as a selectable item instead of only its children.How did you verify your code works?
bun run typecheckinpackages/appbun run test -- dialog-select-directoryinpackages/app/, select root, confirm navigation to root workspace sessionScreenshots / recordings
Not included.
Checklist