fix(cli): add trailing newline to --help output#22125
Open
MuoDoo wants to merge 1 commit intoanomalyco:devfrom
Open
fix(cli): add trailing newline to --help output#22125MuoDoo wants to merge 1 commit intoanomalyco:devfrom
MuoDoo wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22115
Type of change
What does this PR do?
Running
opencode --helpoutputs help text without a trailing newline, causing the shell prompt to appear on the same line as the last line of output.The
show()function inpackages/opencode/src/index.tswrites to stderr viaprocess.stderr.write(), but yargs help output doesn't include a trailing newline. Both code paths (with and without the logo) now check for and appendEOLwhen missing.How did you verify your code works?
Ran
opencode --help 2>&1 | xxd | tail -5before and after the fix:[string](hex5d), no0anewline0a(newline)Screenshots / recordings
N/A — CLI output change, not UI.
Checklist