Open
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22116
Type of change
What does this PR do?
The web UI hides bash tool output during execution even though the streaming data pipeline already delivers it to the client. The TUI shows output in real-time; this PR makes the web UI match.
Three changes:
basic-tool.tsx: Changed thehandleOpenChangeandCollapsible.Arrowgates frompending()(which blocks bothpendingANDrunning) to only block duringpending(LLM still streaming tool call args). Duringrunning, users can toggle the collapsible.message-part.tsx:forceOpen={props.status === "running"}to the bashBasicToolso the collapsible auto-opens when a command starts executing, showing streaming output immediately.!pending()toprops.status !== "pending"so it shows during execution.How did you verify your code works?
Tested locally with
!for i in 1 2 3 4 5; do echo $i; sleep 1; done-- output streams in real-time with the collapsible auto-opened during execution.Checklist