feat(app): replaced not yet dismiss button with view release notes on toaster#22118
Open
winzamark123 wants to merge 1 commit intoanomalyco:devfrom
Open
feat(app): replaced not yet dismiss button with view release notes on toaster#22118winzamark123 wants to merge 1 commit intoanomalyco:devfrom
winzamark123 wants to merge 1 commit intoanomalyco:devfrom
Conversation
…he user can view the release note on one click in the toaster - update the update notification toast actions to replace the dismiss button with a link to the corresponding GitHub release - add "toast.update.action.viewRelease" key to all i18n translation files
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: Related PR Found:
This could be a duplicate or closely related PR that might have already been working on the same functionality. You may want to check if #21846 is still open or if it was closed/merged in favor of #22118. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21847
Type of change
What does this PR do?
Adds a "View release" action button to the update available toast. It opens the GitHub releases tag page for the new version so users can see what changed without manually navigating to GitHub.
I've replaced the "Not yet" dismiss button since the toast already has an X close button that serves the same purpose. This keeps the toast to two actions max and avoids button wrapping.
I also went ahead and update the other languages for "View Release" as well, but let me know if there are any issues with this!
How did you verify your code works?
I've mocked
checkUpdatein the web entry point to return{updateAvailable: true, version "99.0.0"}so that the toaster renders. This was removed after checking the UI looks good.I've also tested the "View Release" and confirms that the link does go to the proper release url.
Screenshots / recordings
Before the change:
After the change:
Checklist