fix: show command as description for shell escape (!) tool calls#22113
Open
leoleoasd wants to merge 1 commit intoanomalyco:devfrom
Open
fix: show command as description for shell escape (!) tool calls#22113leoleoasd wants to merge 1 commit intoanomalyco:devfrom
leoleoasd wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22112
Type of change
What does this PR do?
When using
!shell escape, the tool part is created withinput: { command }but nodescription. The agent-invoked bash tool always provides adescription(a required parameter in the schema) which shows as the subtitle in the Shell tool header. Shell escape commands show nothing.One-line fix in
packages/opencode/src/session/prompt.ts-- setsdescriptionto the command text itself so the user can see what command was run in the tool header.How did you verify your code works?
Ran
bun run dev web, used!sleep 1sshell escape, confirmed the command text now appears as the subtitle in the Shell tool header after completion.Checklist