fix(ui): show "Running commands" instead of "Thinking" while bash tool executes#22111
Open
leoleoasd wants to merge 1 commit intoanomalyco:devfrom
Open
fix(ui): show "Running commands" instead of "Thinking" while bash tool executes#22111leoleoasd wants to merge 1 commit intoanomalyco:devfrom
leoleoasd wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22108
Type of change
What does this PR do?
The web UI shows "Thinking" while the session is busy, even when a bash tool is actively running and the model is just waiting for shell output. This happens because
showThinkinginsession-turn.tsxreturnstrueunconditionally whenshowReasoningSummariesisfalse(the default).The fix tracks whether any bash tool part has
runningorpendingstatus inside the existingassistantDerivedmemo. When a bash tool is active, the shimmer text switches from "Thinking" to "Running commands" using the existing i18n keyui.sessionTurn.status.runningCommands(already translated in all 17 locales).How did you verify your code works?
manually tested. see below.
Screenshots / recordings
before:
after:
Checklist