chore: remove orphaned test-node package#172
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughAll content was removed from Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes an orphaned, always-skipped duplicate test file under packages/test-node/ to reduce confusion and eliminate stale validation logic that diverged from the actively executed JS test suite.
Changes:
- Delete
packages/test-node/index.test.ts, an unused duplicate ofpackages/test-js/index.test.ts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Superseded — restoring test-node as a real Node-runtime test instead of deleting it (it validates the published bundles under Node, which Bun-only CI doesn't cover). |
What
Deletes
packages/test-node/(a singleindex.test.ts).Why
It's dead: not a workspace package (no
package.json), not wired into the roottestscript (onlytest-jsruns), and unreferenced anywhere. Its content duplicatespackages/test-js/index.test.ts, and its name regex/^[a-z\s.()-]+$/iis stale — it would reject "Türkiye". Removing it avoids confusion and a misleading always-skipped duplicate.