Skip to content

chore: remove orphaned test-node package#172

Closed
dmythro wants to merge 1 commit into
mainfrom
chore/remove-test-node
Closed

chore: remove orphaned test-node package#172
dmythro wants to merge 1 commit into
mainfrom
chore/remove-test-node

Conversation

@dmythro

@dmythro dmythro commented Jun 14, 2026

Copy link
Copy Markdown
Member

What

Deletes packages/test-node/ (a single index.test.ts).

Why

It's dead: not a workspace package (no package.json), not wired into the root test script (only test-js runs), and unreferenced anywhere. Its content duplicates packages/test-js/index.test.ts, and its name regex /^[a-z\s.()-]+$/i is stale — it would reject "Türkiye". Removing it avoids confusion and a misleading always-skipped duplicate.

Copilot AI review requested due to automatic review settings June 14, 2026 19:39
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dca1a9bf-5d9c-4744-b4d4-76e429718a8e

📥 Commits

Reviewing files that changed from the base of the PR and between a1c9d77 and bb60f4a.

📒 Files selected for processing (1)
  • packages/test-node/index.test.ts
💤 Files with no reviewable changes (1)
  • packages/test-node/index.test.ts

📝 Walkthrough

Walkthrough

All content was removed from packages/test-node/index.test.ts, reducing it from 73 lines to an empty file. The deleted code included Bun test utility imports, filesystem and path helpers, a distDir constant, two describe('dist') test suites (one validating that ES6/UMD/IIFE exports match source data keys and expose expected functions, one checking that English country name values contain only A–Z characters), and an evalIIFE helper that executed the built dist/index.iife.js in an isolated VM context to simulate <script> tag loading.

Poem

🐇 Hop, hop — the tests have gone away,
No more IIFE checks to run today.
The distDir constant, now just air,
The describe blocks — poof! — no longer there.
A blank file sits where tests once stood,
This bunny hopes the build still should! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove orphaned test-node package' accurately summarizes the main change in the PR, which is the deletion of the orphaned packages/test-node directory.
Description check ✅ Passed The PR description provides clear context about what is being removed and comprehensive reasons why, though it omits the template's checklist items and issue reference section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-test-node

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an orphaned, always-skipped duplicate test file under packages/test-node/ to reduce confusion and eliminate stale validation logic that diverged from the actively executed JS test suite.

Changes:

  • Delete packages/test-node/index.test.ts, an unused duplicate of packages/test-js/index.test.ts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dmythro

dmythro commented Jun 14, 2026

Copy link
Copy Markdown
Member Author

Superseded — restoring test-node as a real Node-runtime test instead of deleting it (it validates the published bundles under Node, which Bun-only CI doesn't cover).

@dmythro dmythro closed this Jun 14, 2026
@dmythro dmythro deleted the chore/remove-test-node branch June 14, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants