Skip to content

chore: bump fsrs version#4956

Open
asukaminato0721 wants to merge 8 commits into
ankitects:mainfrom
asukaminato0721:fsrs-6.3.0
Open

chore: bump fsrs version#4956
asukaminato0721 wants to merge 8 commits into
ankitects:mainfrom
asukaminato0721:fsrs-6.3.0

Conversation

@asukaminato0721

Copy link
Copy Markdown
Contributor

Linked issue (required)

Refs #4080

Summary / motivation (required)

bump fsrs version

Steps to reproduce (required, use N/A if not applicable)

N/A

How to test (required)

Checklist (minimum)

  • I ran ./ninja check or an equivalent relevant check locally.
  • I added or updated tests when the change is non-trivial or behavior changed.

Details

Before / after behavior (optional)

Risk / compatibility / migration (optional)

UI evidence (required for visual changes; otherwise N/A)

Scope

  • This PR is focused on one change (no unrelated edits).

@asukaminato0721

Copy link
Copy Markdown
Contributor Author

cc @L-M-Sherlock

@david-allison

david-allison commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Comment thread rslib/src/scheduler/fsrs/simulator.rs Outdated
Comment thread rslib/src/scheduler/service/mod.rs
@asukaminato0721

Copy link
Copy Markdown
Contributor Author

filled_fsrs_parameters

FSRS-6

@Expertium

Expertium commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@asukaminato0721

  1. I don't see release 6.5.0, only 6.4.1 nvm, it just got released
  2. After Speed up FSRS inference, evaluation, and training without production Burn dependency open-spaced-repetition/fsrs-rs#411 and Speed up compute_parameters without SIMD open-spaced-repetition/fsrs-rs#419, we should use compute parameters with card IDs and compensate for the slight degradation in log loss by bumping the number of epochs from 5 to 8. The speedup will be better that way.
    I believe currently compute_parameters is 4-5x faster than before if we don't use card IDs and keep 5 epochs, and ~9x faster if we do use card IDs and increase epochs 5->8.

Comment thread rslib/src/scheduler/fsrs/params.rs Outdated

@L-M-Sherlock L-M-Sherlock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Expertium

Copy link
Copy Markdown
Contributor

@L-M-Sherlock we can also include your suggestion to remove evaluation after each epoch aka best epoch selector and bump up the number of epochs by 1 to compensate. You said removing evaluation after every epoch makes it ~30% faster.

@sonarqubecloud

Copy link
Copy Markdown

@abdnh abdnh moved this to In progress in Anki Projects Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

6 participants