-
Notifications
You must be signed in to change notification settings - Fork 412
Migrate Compose Glance and Navigation snippets to GitHub #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hamen
wants to merge
20
commits into
android:main
Choose a base branch
from
StellarElements:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3ad4428
Migrate Compose Glance & Navigation snippets
kkuan2011 d79afbb
Existing code compiled. but was not enough elegant for a snippet on DAC.
hamen b2e92f3
To keep the snippet short, similarly to the original one, I added an …
hamen 27b6a2c
This is not a code snippet. This is an API reference, we can find [he…
hamen ac2042c
Cleaned up and made it a bit more Kotlin idiomatic.
hamen e0607f6
Remove the Fragment snippet as we only want to focus on Compose.
hamen 2f2160c
Optimized imports and replace a deprecated call with the suggested one.
hamen 8dba068
Removed the MyAlertDialogFragment as we decided we don't export old V…
hamen 3fa4407
Remove unnecessary file
hamen 0a402e9
Add missing copyright
hamen f42b3c1
Remove log entry
hamen 57f5fb4
Optimize imports
hamen ac28a97
Optimize imports in EdgeToEdgeSnippets.kt
hamen 5f98093
Optimize imports
hamen ba22e49
Add missing throwable parameter
hamen c9adfd8
Merge pull request #1 from StellarElements/katherinekuan/migrate-dac-…
hamen 141d872
Merge branch 'android:main' into main
hamen 51d6430
Add silent to the START_EXCLUDE tag
hamen 072db4d
Merge branch 'main' into main
hamen 341e9bd
Merge branch 'main' into main
hamen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add silent to the tag so ... doesn't show up in the visible snippet on DAC?
// [START_EXCLUDE silent]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅