Skip to content

using 'Component' instead of 'PureComponent' #134

Open
Open
using 'Component' instead of 'PureComponent'#134

Description

@SoYoung210
SoYoung210
opened on Oct 8, 2018

sound-redux/client/src/components/Slider.jsx

Line 22 in 4d857b4

class Slider extends Component {

I think that usually PureComponent is much better than just Component in rendering performance when don't customize shouldComponentUpdate.

Component vs PureComponent in React

Activity

  1. SoYoung210
    added a commit that references this issue on Oct 8, 2018

    [andrewngu#134] fix : Component To PureComponent

    dd41867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions