fix: apply overlap by ownership removal to dynamically created relationships#3363
Open
kzantow wants to merge 4 commits intoanchore:mainfrom
Open
Conversation
…hip relationships Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-on to a change made to dynamically create
ownership-by-file-overlaprelationships based on file locations. These dynamic relationships were added after a set of packages were dropped, so the same logic was not applying to them. In particular, this corrects a deficiency in Syft-generated CycloneDX documents, since these should have the correct metadata but do not have the relationships since CycloneDX cannot express that.Related to at least #3329 and anchore/syft#4760
This PR also seems to reduce memory usage slightly beyond #3355 to the range of ~75-80 MB for the same SBOM.