feat: ignore overlapping fixed vulns for rpm + more#3326
Draft
kzantow wants to merge 11 commits intoanchore:mainfrom
Draft
feat: ignore overlapping fixed vulns for rpm + more#3326kzantow wants to merge 11 commits intoanchore:mainfrom
kzantow wants to merge 11 commits intoanchore:mainfrom
Conversation
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
…fied Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
…rror Signed-off-by: Keith Zantow <kzantow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #3286, which ignores fixed vulnerabilities by overlapping file path and ownership-by-file-overlap relationship, this PR follows-on based on the #3286 changes from for RPM and other matchers. This PR (as well as the alternate implementation in #3304) have the result of fixing quite a lot of the reported SLES issues where we have fixed information for specific RPM packages but the Python packages result in the same vulnerability.
An example using
SLES 15.6andurllib3(withdocker build -t suse-overlap:latest):Based on the vulnerabilities in the Grype database for
15.6:Current grype reports:
This branch reports:
Note the removal of:
These 2 vulnerabilities are reported in the SUSE data as fixed for the installed version, while the separate 1.25.11 version which was not installed via SUSE's package manager retains its vulnerabilities.