og_entity_access is too strict#288
Open
chx wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks. Would you mind also adding a test case to confirm a user has indeed access to edit itself. |
Owner
|
I have tested on a clean installation, and a regular user is still able to edit own user page. @chx can you please provide steps to reproduce |
pfrenssen
pushed a commit
to ec-europa/og
that referenced
this pull request
Jul 25, 2017
Provide a method to check if an OgRole is a default role
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not think we need to explicitly forbid at the end of the day. For example, as far as I can see users can no longer edit themselves because of this.