Skip to content

Remove auto-prefixing on save since this prefixes already-prefixed ro…#235

Closed
catch56 wants to merge 1 commit into
amitaibu:8.x-1.xfrom
catch56:role-duplicates
Closed

Remove auto-prefixing on save since this prefixes already-prefixed ro…#235
catch56 wants to merge 1 commit into
amitaibu:8.x-1.xfrom
catch56:role-duplicates

Conversation

@catch56

@catch56 catch56 commented Jun 13, 2016

Copy link
Copy Markdown

…le entities during configuration import.

This doesn't yet re-add the prefixing anywhere. Could do that in the form maybe? Or add validation to stop duplicates being created?

@pfrenssen

Copy link
Copy Markdown
Collaborator

There is an issue about this: #216. A possible way to fix this is proposed in that issue. We can set a 'name' that can be used to construct the ID on save.

@pfrenssen

Copy link
Copy Markdown
Collaborator

@catch56 in #217 (comment) @amitaibu proposed to let GroupManager::getDefaultRoles() to return partially populated OgRole objects instead of arrays. I am going to implement that now. In order to make that work I need to fix this issue with the prefixing on save too.

I'm going to work on that now. Just so you know that this is going to be addressed shortly, and we won't do duplicate work. I'll link the PR as soon as I got something.

@pfrenssen

Copy link
Copy Markdown
Collaborator

A proposed fix is included in #237. Closing this as a duplicate.

@pfrenssen pfrenssen closed this Jun 14, 2016
RoySegall pushed a commit that referenced this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants