Groups added to the 'Other groups' field are lost on submit

[pfrenssen]

I noticed that the 'Other Groups' field is not working at all. There are two bugs there:

• If the 'Group Audience' field is left empty, a target reference with ID NULL is added to the list.
• The wrong element in the $form array is inspected when looking for the field.

A third bug is preventing the tests from completing:

• The config schema for the complex widget is missing.

This has been split off from the larger work of converting the OG Complex widget tests in #140, so that this important fix can go through without waiting for that mammoth task to complete. I have also cherry-picked the two commits from #147 that allow us to run functional tests on Travis.

[pfrenssen]

Above test fails correctly because it detects that it is impossible to add groups through the 'Other groups' field.

[pfrenssen]

This fixes it and should turn the test green. Note that there is still a bug left: it now hardcodes the field name, so it only works for one group audience field. This will be tackled when I get to OgComplexWidgetTest::testMultipleFields().

[damiankloip]

$this->fieldDefinition->getName() 👍

[pfrenssen]

Thanks @damiankloip! Much obliged :)

[amitaibu]

as indicated in the issue, this one troubles me a bit (even if it's an intermediate step). I'd be happy to see the next step to make this work for all audience fields

[pfrenssen]

Ok let's do #144 first, it should be pretty trivial.

[pfrenssen]

The tests started failing after merging in the master branch. It was due to the OgStandardReferenceItem that was added in #128 - it was using the wrong validator, causing the following error when saving a node that references a group:

Error: Call to undefined method Drupal\Core\TypedData\Plugin\DataType\IntegerData::isEmpty() in Drupal\Core\Entity\Plugin\Validation\Constraint\ValidReferenceConstraintValidator->validate() (line 78 of core/lib/Drupal/Core/Entity/Plugin/Validation/Constraint/ValidReferenceConstraintValidator.php).

This test was actually detecting that already :)

@amitaibu, I have fixed the visibility of the group audience field in #153, this is merged into this issue. The fix to make it work with all audience fields has also been applied. Is there anything else that needs to be done here?

[pfrenssen]

I created a separate issue for the fatal error when saving group content, so that it is more easily discoverable if someone runs into this problem: #154.

[RoySegall]

@amitaibu Checked it and the other groups widget works very good.

[amitaibu]

Merged, thanks!