Skip to content

Move VTD repo changes to Vitis-AI-Telluride#1288

Open
ManojTakasi wants to merge 1 commit intoamd:mainfrom
ManojTakasi:vtd_changes
Open

Move VTD repo changes to Vitis-AI-Telluride#1288
ManojTakasi wants to merge 1 commit intoamd:mainfrom
ManojTakasi:vtd_changes

Conversation

@ManojTakasi
Copy link
Copy Markdown
Contributor

Move VTD repo changes to Vitis-AI-Telluride

Signed-off-by: Takasi, Manoj <Manoj.Takasi@amd.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VE2 shim to stop pulling VE2 validate/SMI artifacts from the VTD repo and adjusts the VE2 SMI archive filename expected at runtime.

Changes:

  • Update VE2 archive_path query to reference xrt_smi_ve2.a instead of xrt_smi_ve2.ar.
  • Remove CMake logic that downloaded and installed the VE2 VTD archive and aie_ddr_connections resources during build/install.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/shim_ve2/xdna_device.cpp Updates the runtime path for the VE2 SMI archive.
src/shim_ve2/CMakeLists.txt Removes download/install staging of VE2 VTD/validate artifacts.
Comments suppressed due to low confidence (1)

src/shim_ve2/CMakeLists.txt:38

  • The VE2 shim no longer installs any of the amdxdna/bins data files (previously the VTD/validate artifacts), but the shim still advertises an archive_path pointing under ${prefix}/share/amdxdna/bins/. A standalone cmake --install for XDNA_VE2 will therefore produce an incomplete installation where VE2 SMI/validate can’t find its archive (and related resources). If the intent is to move these artifacts to another repo/package, please add an explicit build-time check/message or an option to fetch/install them, or update the VE2 packaging flow to stage the needed files.
install (TARGETS ${XDNA_VE2_TARGET} 
  EXPORT xrt-targets 
  LIBRARY DESTINATION ${XRT_INSTALL_LIB_DIR}
  )


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 515 to 518
get(const xrt_core::device* device, key_type key)
{
return std::string(get_shim_data_dir() + "bins/xrt_smi_ve2.ar");
return std::string(get_shim_data_dir() + "bins/xrt_smi_ve2.a");
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants