Move VTD repo changes to Vitis-AI-Telluride#1288
Open
ManojTakasi wants to merge 1 commit intoamd:mainfrom
Open
Move VTD repo changes to Vitis-AI-Telluride#1288ManojTakasi wants to merge 1 commit intoamd:mainfrom
ManojTakasi wants to merge 1 commit intoamd:mainfrom
Conversation
Signed-off-by: Takasi, Manoj <Manoj.Takasi@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the VE2 shim to stop pulling VE2 validate/SMI artifacts from the VTD repo and adjusts the VE2 SMI archive filename expected at runtime.
Changes:
- Update VE2
archive_pathquery to referencexrt_smi_ve2.ainstead ofxrt_smi_ve2.ar. - Remove CMake logic that downloaded and installed the VE2 VTD archive and
aie_ddr_connectionsresources during build/install.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shim_ve2/xdna_device.cpp | Updates the runtime path for the VE2 SMI archive. |
| src/shim_ve2/CMakeLists.txt | Removes download/install staging of VE2 VTD/validate artifacts. |
Comments suppressed due to low confidence (1)
src/shim_ve2/CMakeLists.txt:38
- The VE2 shim no longer installs any of the
amdxdna/binsdata files (previously the VTD/validate artifacts), but the shim still advertises anarchive_pathpointing under${prefix}/share/amdxdna/bins/. A standalonecmake --installfor XDNA_VE2 will therefore produce an incomplete installation where VE2 SMI/validate can’t find its archive (and related resources). If the intent is to move these artifacts to another repo/package, please add an explicit build-time check/message or an option to fetch/install them, or update the VE2 packaging flow to stage the needed files.
install (TARGETS ${XDNA_VE2_TARGET}
EXPORT xrt-targets
LIBRARY DESTINATION ${XRT_INSTALL_LIB_DIR}
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
515
to
518
| get(const xrt_core::device* device, key_type key) | ||
| { | ||
| return std::string(get_shim_data_dir() + "bins/xrt_smi_ve2.ar"); | ||
| return std::string(get_shim_data_dir() + "bins/xrt_smi_ve2.a"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move VTD repo changes to Vitis-AI-Telluride