Skip to content

Windows support#136

Open
astrelsky wants to merge 1 commit into
amd:develfrom
astrelsky:windows
Open

Windows support#136
astrelsky wants to merge 1 commit into
amd:develfrom
astrelsky:windows

Conversation

@astrelsky

@astrelsky astrelsky commented Jul 18, 2026

Copy link
Copy Markdown

Describe the intent of your PR here. Added Windows support, pretty self explanatory and should have been included from the beginning. (I'm aware the llvm and mlir dependencies were the main limiting factor).

Added

  • Added test skip validation for missing gated weights to stabilize local test executions.

Changed

  • Switched to using time.perf_counter_ns to prevent divide by 0 errors.
  • Hoisted object FIFO acquires out of conditional structures to satisfy cyclostatic compiler analysis constraints.
  • Swapped shell/awk commands for platform-independent Python execution blocks to handle symbol mapping on Windows.

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR has been reviewed and approved.
  3. All checks are passing.
================================================== warnings summary ===================================================
iron/operators/dequant/test.py::test_dequant[iter0-input_length_1024-num_aie_columns_1-num_channels_1-tile_size_1024-group_size_32]
  D:\IRON\iron\operators\dequant\reference.py:42: UserWarning: torch.quantize_per_tensor, torch.quantize_per_channel and other quantized tensor creation functions that produce tensors with dtype torch.quint8, torch.qint8, and torch.qint32 are deprecated and will be removed in a future PyTorch release. Please see https://github.com/pytorch/pytorch/issues/184982 for more information. (Triggered internally at D:/b/torch/aten/src/ATen/quantized/Quantizer.cpp:116.)
    A = torch.quantize_per_channel(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================== 2830 passed, 25 skipped, 1 warning in 1032.96s (0:17:12) ===============================

The test run results shown above was faster because I left the build folder in place after realizing how to fix the divide by 0 error I was encountering with the latency_us calculations, it had previously taken 2029.72s (0:33:49).

I used the llvm-aie, mlir-aie-no-rtti and mlir-air that were installed when I installed triton-windows. The restrictions in requirements.txt are too strict for the versions and there was no windows wheel for those.

llvm-aie                   21.0.0.2026071801+ce8c0f8f
mlir-aie-no-rtti           1.3.4.dev19+g92e9475
mlir-air                   0.0.1.2026071405+c7ee42f.no.rtti

- Switched to using ``time.perf_counter_ns`` to prevent divide by 0 errors.
- Hoisted object FIFO acquires out of conditional structures to satisfy cyclostatic compiler analysis constraints.
- Swapped shell/awk commands for platform-independent Python execution blocks to handle symbol mapping on Windows.
- Added test skip validation for missing gated weights to stabilize local test executions.

Co-authored-by: Gemini AI <gemini-ai@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant