Windows support#136
Open
astrelsky wants to merge 1 commit into
Open
Conversation
- Switched to using ``time.perf_counter_ns`` to prevent divide by 0 errors. - Hoisted object FIFO acquires out of conditional structures to satisfy cyclostatic compiler analysis constraints. - Swapped shell/awk commands for platform-independent Python execution blocks to handle symbol mapping on Windows. - Added test skip validation for missing gated weights to stabilize local test executions. Co-authored-by: Gemini AI <gemini-ai@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the intent of your PR here. Added Windows support, pretty self explanatory and should have been included from the beginning. (I'm aware the llvm and mlir dependencies were the main limiting factor).
Added
Changed
time.perf_counter_nsto prevent divide by 0 errors.PR Merge Checklist
develcommit and pointing todevel.The test run results shown above was faster because I left the build folder in place after realizing how to fix the divide by 0 error I was encountering with the
latency_uscalculations, it had previously taken2029.72s (0:33:49).I used the
llvm-aie,mlir-aie-no-rttiandmlir-airthat were installed when I installed triton-windows. The restrictions inrequirements.txtare too strict for the versions and there was no windows wheel for those.