Skip to content

fix: issue-53, compute retention_time even if flush_interval is with … #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titouanj merged 1 commit into from
Jul 7, 2026
Merged

fix: issue-53, compute retention_time even if flush_interval is with … #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/alumet/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.8.1
version: 0.8.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand All @@ -33,5 +33,5 @@ dependencies:
version: 0.7.0
condition: alumet-relay-server.enabled
- name: alumet-relay-client
version: 0.8.1
version: 0.8.2
condition: alumet-relay-client.enabled
2 changes: 1 addition & 1 deletion charts/alumet/charts/alumet-relay-client/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.8.1
version: 0.8.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
20 changes: 9 additions & 11 deletions charts/alumet/charts/alumet-relay-client/alumet-agent.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,10 @@ ref = "cpu_energy"
# Eg: If the metrics come from sources poll/flush every 1 second, it's recommanded to define the retention_time to at least 2 seconds.
# This way the plugin can make use of the precedent values of this metric to make interpolations.
{{- $val := .Values.plugins.rapl.flush_interval | toString }}
{{- $lastChar := substr (int (sub (len $val) 1)) (int (len $val)) $val }}
{{ $poll := trimSuffix $lastChar .Values.plugins.rapl.flush_interval | int -}}
{{- $new_poll := add $poll 1 -}}

retention_time = "{{ $new_poll }}{{ $lastChar }}"
{{ $unit := regexReplaceAll "^[0-9]+" $val "" }}
{{ $numeric := regexReplaceAll "[^0-9]" $val "" }}
{{ $new_poll := add $numeric 1 -}}
retention_time = "{{ $new_poll }}{{ $unit }}"

# Timeseries related to the resources.
[plugins.energy-attribution.formulas.attributed_rapl_energy.per_resource]
Expand Down Expand Up @@ -157,12 +156,11 @@ ref = "gpu_energy"
# This need to be coherent with the poll_interval/flush_interval of the metrics involved in this formula.
# Eg: If the metrics come from sources poll/flush every 1 second, it's recommanded to define the retention_time to at least 2 seconds.
# This way the plugin can make use of the precedent values of this metric to make interpolations.
{{- $val := .Values.plugins.nvml.flush_interval | toString }}
{{- $lastChar := substr (int (sub (len $val) 1)) (int (len $val)) $val }}
{{ $poll := trimSuffix $lastChar .Values.plugins.nvml.flush_interval | int -}}
{{- $new_poll := add $poll 1 -}}

retention_time = "{{ $new_poll }}{{ $lastChar }}"
{{ $val := .Values.plugins.nvml.flush_interval | toString }}
{{ $unit := regexReplaceAll "^[0-9]+" $val "" }}
{{ $numeric := regexReplaceAll "[^0-9]" $val "" }}
{{ $new_poll := add $numeric 1 -}}
retention_time = "{{ $new_poll }}{{ $unit }}"

[plugins.energy-attribution.formulas.attributed_nvml_energy.per_resource]
gpu_energy = { metric = "nvml_energy_consumption", resource_kind = "gpu" }
Expand Down
Loading